[SDK] Default to in-memory storage for inAppWallet outside browser #7038

joaquim-verges · 2025-05-13T21:34:14Z

PR-Codex overview

This PR focuses on enhancing the inAppWallet functionality by introducing default in-memory storage for non-browser environments, adding integration tests, and improving documentation regarding wallet strategies and features.

Detailed summary

Default storage switched to in-memory when not in the browser.
New getDefaultStorage() function implemented.
Added integration tests for InAppWallet covering backend and guest strategies.
Enhanced documentation for inAppWallet with examples for EIP-7702 and EIP-4337.
Updated login methods documentation, including email and phone verification.
Added options for customizing the Connect UI with logo, icon, and name.
Clarified storage behavior for wallet state management.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel · 2025-05-13T21:34:16Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 14, 2025 1:29am
login	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 14, 2025 1:29am
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 14, 2025 1:29am
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 14, 2025 1:29am
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 14, 2025 1:29am

changeset-bot · 2025-05-13T21:34:17Z

🦋 Changeset detected

Latest commit: 72eb633

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
thirdweb	Patch
@thirdweb-dev/wagmi-adapter	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

joaquim-verges · 2025-05-13T21:34:29Z

[SDK] Default to in-memory storage for inAppWallet outside browser #7038 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

packages/thirdweb/src/wallets/in-app/web/types.ts

packages/thirdweb/src/wallets/in-app/web/lib/web-connector.ts

packages/thirdweb/src/wallets/in-app/web/in-app.ts

github-actions · 2025-05-14T01:25:33Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	54.21 KB (0%)	1.1 s (0%)	172 ms (+65.65% 🔺)	1.3 s
thirdweb (cjs)	193.92 KB (0%)	3.9 s (0%)	452 ms (+11.49% 🔺)	4.4 s
thirdweb (minimal + tree-shaking)	5.68 KB (0%)	114 ms (0%)	74 ms (+1002.56% 🔺)	188 ms
thirdweb/chains (tree-shaking)	524 B (0%)	11 ms (0%)	10 ms (+134.88% 🔺)	20 ms
thirdweb/react (minimal + tree-shaking)	19.53 KB (0%)	391 ms (0%)	91 ms (+347.08% 🔺)	481 ms

codecov · 2025-05-14T01:27:12Z

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 55.51%. Comparing base (1c31a1e) to head (72eb633).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...irdweb/src/wallets/in-app/web/lib/web-connector.ts	62.50%	3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (62.50%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7038      +/-   ##
==========================================
+ Coverage   54.89%   55.51%   +0.61%     
==========================================
  Files         909      909              
  Lines       58396    58403       +7     
  Branches     4035     4072      +37     
==========================================
+ Hits        32056    32420     +364     
+ Misses      26235    25877     -358     
- Partials      105      106       +1

Flag	Coverage Δ
packages	`55.51% <62.50%> (+0.61%)`	⬆️

Files with missing lines	Coverage Δ
packages/thirdweb/src/wallets/in-app/web/in-app.ts	`100.00% <ø> (ø)`
...irdweb/src/wallets/in-app/web/lib/web-connector.ts	`47.61% <62.50%> (+0.17%)`	⬆️

... and 15 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions bot assigned joaquim-verges May 13, 2025

github-actions bot added packages SDK Involves changes to the thirdweb SDK labels May 13, 2025

vercel bot had a problem deploying to Preview – thirdweb-www May 13, 2025 21:35 Failure

vercel bot had a problem deploying to Preview – wallet-ui May 13, 2025 21:35 Failure

vercel bot had a problem deploying to Preview – login May 13, 2025 21:35 Failure

vercel bot had a problem deploying to Preview – docs-v2 May 13, 2025 21:35 Failure

vercel bot had a problem deploying to Preview – thirdweb_playground May 13, 2025 21:36 Failure

joaquim-verges marked this pull request as ready for review May 13, 2025 21:38

joaquim-verges requested review from a team as code owners May 13, 2025 21:38

joaquim-verges changed the title ~~Default to in-memory storage for inAppWallet outside browser~~ [SDK] Default to in-memory storage for inAppWallet outside browser May 13, 2025

joaquim-verges force-pushed the Default_to_in-memory_storage_for_inAppWallet_outside_browser branch from c6c3cd7 to 233001c Compare May 13, 2025 21:49

vercel bot had a problem deploying to Preview – thirdweb-www May 13, 2025 21:50 Failure

vercel bot had a problem deploying to Preview – wallet-ui May 13, 2025 21:50 Failure

vercel bot had a problem deploying to Preview – login May 13, 2025 21:50 Failure

vercel bot had a problem deploying to Preview – docs-v2 May 13, 2025 21:50 Failure

vercel bot had a problem deploying to Preview – thirdweb_playground May 13, 2025 21:50 Failure

graphite-app bot reviewed May 13, 2025

View reviewed changes

packages/thirdweb/src/wallets/in-app/web/types.ts Outdated Show resolved Hide resolved

graphite-app bot reviewed May 13, 2025

View reviewed changes

packages/thirdweb/src/wallets/in-app/web/lib/web-connector.ts Show resolved Hide resolved

packages/thirdweb/src/wallets/in-app/web/in-app.ts Outdated Show resolved Hide resolved

Default to in-memory storage for inAppWallet outside browser

72eb633

joaquim-verges force-pushed the Default_to_in-memory_storage_for_inAppWallet_outside_browser branch from 233001c to 72eb633 Compare May 14, 2025 01:20

vercel bot deployed to Preview – login May 14, 2025 01:22 View deployment

vercel bot deployed to Preview – wallet-ui May 14, 2025 01:22 View deployment

vercel bot deployed to Preview – thirdweb_playground May 14, 2025 01:23 View deployment

vercel bot deployed to Preview – thirdweb-www May 14, 2025 01:27 View deployment

vercel bot deployed to Preview – docs-v2 May 14, 2025 01:29 View deployment

joaquim-verges merged commit da3fc99 into main May 14, 2025
23 of 24 checks passed

joaquim-verges deleted the Default_to_in-memory_storage_for_inAppWallet_outside_browser branch May 14, 2025 01:32

joaquim-verges mentioned this pull request May 13, 2025

Version Packages #7032

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SDK] Default to in-memory storage for inAppWallet outside browser #7038

[SDK] Default to in-memory storage for inAppWallet outside browser #7038

Uh oh!

joaquim-verges commented May 13, 2025 •

edited by pr-codex bot

Loading

Uh oh!

vercel bot commented May 13, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented May 13, 2025 •

edited

Loading

Uh oh!

joaquim-verges commented May 13, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented May 14, 2025

Uh oh!

codecov bot commented May 14, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[SDK] Default to in-memory storage for inAppWallet outside browser #7038

[SDK] Default to in-memory storage for inAppWallet outside browser #7038

Uh oh!

Conversation

joaquim-verges commented May 13, 2025 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Uh oh!

vercel bot commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

joaquim-verges commented May 13, 2025

How to use the Graphite Merge Queue

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented May 14, 2025

size-limit report 📦

Uh oh!

codecov bot commented May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

joaquim-verges commented May 13, 2025 •

edited by pr-codex bot

Loading

vercel bot commented May 13, 2025 •

edited

Loading

changeset-bot bot commented May 13, 2025 •

edited

Loading

codecov bot commented May 14, 2025 •

edited

Loading